-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New grayscale style #1164
New grayscale style #1164
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1164 +/- ##
==========================================
+ Coverage 93.11% 93.39% +0.28%
==========================================
Files 94 94
Lines 9289 9995 +706
==========================================
+ Hits 8649 9335 +686
- Misses 640 660 +20
Continue to review full report at Codecov.
|
axes.linewidth: 1 | ||
axes.spines.top: False | ||
axes.spines.right: False | ||
image.cmap: gray |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what cmap is this? The mpl default or the one in colorcet (etc+)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default from matplotlib, as I understand this one is perceptually uniform. But I could check again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:( OK, I will fix it
updated cmap figures I was unsure if we should use the linear_grey_10_95_c0 or linear_grey_0_100_c0 scales. The first one does not include the extreme values, i.e the white and black. @ahartikainen What do you think? |
This is nice! |
If this is meant for printed book format should we ask publishers which plot will look better in print? My assumption for book is if readers decide to reproduce on computer the limitation of grayscale wont apply anymore and we tell them to use full colorscale, so this styles main use case is printed material |
Also, for printing, we can force colours to be a bit lighter |
Adds new grayscale style. Originally intended for the BMCP book but probably useful for a more general use. It is based on the arviz-white style, but the color cycle has only five colors the first four are grays and the fifth is the ArviZ's "C0 blue", the cmap is matplotlib's gray cmap
A few examples from the gallery (some of with their default colors changed)