Pairplot of two variables with bokeh #1179
Conversation
…es (#1079) * add jointplot features into pairplot * add scatter_kde kind for pairplot * add point_estimate arguments * bokeh backend * fix None argument for color in kdeplot bokeh backend * run black, pylint and pytest * remove scatter_kde kind among several other changes * minor changes * run pytest * add plot width and height to backend_kwargs fix pylint issues fix hover feature fix hover feature minor fixes * update docstring run pylint * update changelog
* Transform colors to hex in plot_khat * Reformatted with black * Added hex conversion to khatplot.py and vectorized_to_hex to plot_utils.py * Black changes * Added keep_alpha parameter and list comprehension * Pydocstyle changes * More pydocstyle changes * generalised vectorized_to_hex * Black changes * Black changes * Modified khatplot hline_kwargs, vectorized_to_hex and test for vectorized_to_hex * Black changes * Rewrote tests and modified vectorized_to_hex * lint and minor fixes Co-authored-by: Oriol (ZBook) <oriol.abril.pla@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1179 +/- ##
=======================================
Coverage 93.11% 93.12%
=======================================
Files 94 94
Lines 9339 9351 +12
=======================================
+ Hits 8696 8708 +12
Misses 643 643
Continue to review full report at Codecov.
|
| @@ -19,6 +19,7 @@ | |||
| * New grayscale style. This also add two new cmaps `cet_grey_r` and `cet_grey_r`. These are perceptually uniform gray scale cmaps from colorcet (linear_grey_10_95_c0) (#1164) | |||
| * Add warmup groups to InferenceData objects, initial support for PyStan (#1126) and PyMC3 (#1171) | |||
|
|
|||
There was a problem hiding this comment.
Being picky here. Looks like theres a blank line that can be removed
There was a problem hiding this comment.
Is this changelog item correct? It feels like this PR is internally facing readability changes (which is great) but the feature described here ie something else?
There was a problem hiding this comment.
It was a duplicated line. Thank you for your helpful comment
| @@ -179,7 +185,7 @@ def get_width_and_height(jointplot, rotate): | |||
| row_ax.append(None) | |||
| else: | |||
| jointplot = row == col and numvars == 2 and marginals | |||
| rotate = n == 1 | |||
| rotate = col == 1 | |||
There was a problem hiding this comment.
Thanks, much easier to read now
…es (#1079) * add jointplot features into pairplot * add scatter_kde kind for pairplot * add point_estimate arguments * bokeh backend * fix None argument for color in kdeplot bokeh backend * run black, pylint and pytest * remove scatter_kde kind among several other changes * minor changes * run pytest * add plot width and height to backend_kwargs fix pylint issues fix hover feature fix hover feature minor fixes * update docstring run pylint * update changelog
|
Ship it! |
|
Ah shoot I merged a little too quickly, which is fine. Next time do a rebase on master so the changes from master dont appear in this PR. Ill slow down next time, my bad |
|
Basically thing change shouldnt have appeared in set of commits
|
Description
This PR addresses issue #1169.
Checklist