fixes to matplotlib subplot handling #1205
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor changes to matplotlib subplot handling in
plot_trace
andplot_pair
.In
plot_trace
plot.max_subplots
used to be checked on the number of rows in plot trace, this PR fixes it to check the actual number of subplots.I also checked the behaviour in plot_pair to check that it takes into account the actual number of used subplots with or without marginals. I have also modified axes creation to avoid having extra blank spaces at the top and right of with
marginals=False
(see https://arviz-devs.github.io/arviz/examples/matplotlib/mpl_plot_pair.html for example)Checklist