Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test on both pymc3 master and release #1207

Merged
merged 5 commits into from
May 24, 2020
Merged

test on both pymc3 master and release #1207

merged 5 commits into from
May 24, 2020

Conversation

OriolAbril
Copy link
Member

Description

We missed a bug that could have been caught testing on latest pymc3 release, given that we do have 2 external CI jobs, I have configured it so that one runs on master and another on latest release.

Checklist

Copy link
Contributor

@ahartikainen ahartikainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@OriolAbril OriolAbril force-pushed the test_pymc_release branch from 9c07c40 to 00e66dc Compare May 24, 2020 16:26
@codecov
Copy link

codecov bot commented May 24, 2020

Codecov Report

Merging #1207 into master will increase coverage by 2.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1207      +/-   ##
==========================================
+ Coverage   90.87%   93.10%   +2.22%     
==========================================
  Files          94       94              
  Lines        9480     9480              
==========================================
+ Hits         8615     8826     +211     
+ Misses        865      654     -211     
Impacted Files Coverage Δ
arviz/data/io_pymc3.py 91.60% <0.00%> (-0.41%) ⬇️
arviz/data/converters.py 68.57% <0.00%> (+1.42%) ⬆️
arviz/data/io_emcee.py 98.33% <0.00%> (+5.00%) ⬆️
arviz/data/io_pystan.py 98.67% <0.00%> (+45.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5784b5...00e66dc. Read the comment docs.

@OriolAbril OriolAbril merged commit 888a534 into master May 24, 2020
@OriolAbril OriolAbril deleted the test_pymc_release branch May 24, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants