Fix inconsistent capitalization in plot_hdi docstring #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1221 +/- ##
=======================================
Coverage 93.07% 93.07%
=======================================
Files 94 94
Lines 9504 9504
=======================================
Hits 8846 8846
Misses 658 658
Continue to review full report at Codecov.
|
OriolAbril
approved these changes
Jun 4, 2020
There was a problem hiding this comment.
LGTM, thanks for the PR!
About updating the changelog, should I add it under v0.x.x Unreleased or under v0.8.3 (2020 May 28)? Kindly help out in that regard
It should go in the Documentation section of v0.x.x
OriolAbril
reviewed
Jun 4, 2020
Co-authored-by: Oriol Abril <oriol.abril.pla@gmail.com>
|
Thanks @neha-shah99 ! Docs are automatically updated with every commit, so you'll be able to see the changes in 20-30 minutes at https://arviz-devs.github.io/arviz/generated/arviz.plot_hdi.html#arviz.plot_hdi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1193.
Have corrected the capitalization inconsistency pointed out in the issue and added '.' wherever missing.
About updating the changelog, should I add it under v0.x.x Unreleased or under v0.8.3 (2020 May 28)? Kindly help out in that regard
Checklist