Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow from_pymc3 args to override model values #1249

Merged
merged 4 commits into from
Jun 19, 2020
Merged

Conversation

OriolAbril
Copy link
Member

Description

Also related (and blocker) of pymc-devs/pymc#3963

Checklist

  • Follows official PR format
  • New features are properly documented (with an example if appropriate)?
    • will be in radon notebook
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #1249 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1249   +/-   ##
=======================================
  Coverage   93.11%   93.11%           
=======================================
  Files          98       98           
  Lines        9714     9715    +1     
=======================================
+ Hits         9045     9046    +1     
  Misses        669      669           
Impacted Files Coverage Δ
arviz/data/io_pymc3.py 92.36% <100.00%> (+0.02%) ⬆️
arviz/plots/pairplot.py 92.77% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cec6dd...ebdc4d8. Read the comment docs.

@OriolAbril
Copy link
Member Author

ready to merge :)

@OriolAbril OriolAbril merged commit f2c954e into master Jun 19, 2020
@OriolAbril OriolAbril deleted the autocoords_update branch June 19, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants