Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plot_posterior: fix overlap of hdi and rope #1263

Merged
merged 2 commits into from
Jun 24, 2020
Merged

plot_posterior: fix overlap of hdi and rope #1263

merged 2 commits into from
Jun 24, 2020

Conversation

aloctavodia
Copy link
Contributor

@aloctavodia aloctavodia commented Jun 23, 2020

Fixes #1262

  • Follows official PR format
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #1263 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1263   +/-   ##
=======================================
  Coverage   93.21%   93.21%           
=======================================
  Files          98       98           
  Lines        9734     9734           
=======================================
  Hits         9074     9074           
  Misses        660      660           
Impacted Files Coverage Δ
arviz/plots/backends/matplotlib/posteriorplot.py 98.09% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d9297c...136baae. Read the comment docs.

Copy link
Contributor

@AlexAndorra AlexAndorra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Osvaldo 👌
Will merge later today in case anybody has some comments

@AlexAndorra AlexAndorra merged commit f2f1d98 into master Jun 24, 2020
@AlexAndorra AlexAndorra deleted the overlap_pp branch June 24, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HPD plot shows values over each other
2 participants