Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plot_ppc add observed argument to (un)plot observed data #1422

Merged
merged 3 commits into from
Oct 19, 2020
Merged

Conversation

aloctavodia
Copy link
Contributor

@aloctavodia aloctavodia commented Oct 16, 2020

  • Follows official PR format
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

I also made a few other changes in bokeh, specially to use the matplotlib color and to make the scatter plot a little fit faster.

@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #1422 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1422   +/-   ##
=======================================
  Coverage   91.56%   91.57%           
=======================================
  Files         105      105           
  Lines       11098    11107    +9     
=======================================
+ Hits        10162    10171    +9     
  Misses        936      936           
Impacted Files Coverage Δ
arviz/plots/backends/bokeh/ppcplot.py 97.69% <100.00%> (+0.11%) ⬆️
arviz/plots/backends/matplotlib/ppcplot.py 98.10% <100.00%> (+0.02%) ⬆️
arviz/plots/ppcplot.py 93.44% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9870c8...2ea6b87. Read the comment docs.

Comment on lines 55 to 56
mean: bool
Whether or not to plot the observed data. Defaults to True
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mean: bool
Whether or not to plot the observed data. Defaults to True
observed: bool, default True
Whether or not to plot the observed data.

@aloctavodia aloctavodia merged commit 0e4e188 into master Oct 19, 2020
@aloctavodia aloctavodia deleted the ppc_obs branch October 19, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants