Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compare and make stacking default method #1438

Merged
merged 2 commits into from
Nov 9, 2020
Merged

Conversation

aloctavodia
Copy link
Contributor

@aloctavodia aloctavodia commented Nov 6, 2020

When using "bb-pseudo-bma" overflows could happen when a weight much more larger than the rest.
I found mistakes in stacking, the retains where not ok and the minimization always return the initial guess 1/(number of model) oddly I know for sure it used to run OK. Anyway, this fix the problem and makes stacking the default method.

This also add a warning message that we changed the default method. I guess we should keep it at least during one release cycle.

  • Follows official PR format
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #1438 (7ed6eb9) into master (9c21881) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1438      +/-   ##
==========================================
+ Coverage   91.91%   91.93%   +0.01%     
==========================================
  Files         105      105              
  Lines       11207    11208       +1     
==========================================
+ Hits        10301    10304       +3     
+ Misses        906      904       -2     
Impacted Files Coverage Δ
arviz/stats/stats.py 96.39% <100.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c21881...7ed6eb9. Read the comment docs.

@aloctavodia aloctavodia merged commit 44ceb08 into master Nov 9, 2020
@aloctavodia aloctavodia deleted the fix_compare branch November 9, 2020 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant