fix compare and make stacking default method #1438
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using "bb-pseudo-bma" overflows could happen when a weight much more larger than the rest.
I found mistakes in stacking, the retains where not ok and the minimization always return the initial guess 1/(number of model) oddly I know for sure it used to run OK. Anyway, this fix the problem and makes stacking the default method.
This also add a warning message that we changed the default method. I guess we should keep it at least during one release cycle.