Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes before releasing #1495

Merged
merged 3 commits into from
Jan 15, 2021
Merged

Fixes before releasing #1495

merged 3 commits into from
Jan 15, 2021

Conversation

OriolAbril
Copy link
Member

@OriolAbril OriolAbril commented Jan 11, 2021

Description

Fixes from_pymc3 compatibility with theano-pymc>=1.1 and allows going back to the original behaviour of from_pymc3 with DensityDist if desired.

Tagging also @michaelosthege for review

Checklist

  • Does the PR follow official
    PR format?
  • Is the code style correct (follows pylint and black guidelines)?
  • Is the fix listed in the Maintenance and fixes
    section of the changelog?

@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #1495 (cfdf83f) into master (f7651e0) will decrease coverage by 0.52%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1495      +/-   ##
==========================================
- Coverage   91.96%   91.44%   -0.53%     
==========================================
  Files         105      105              
  Lines       11244    11391     +147     
==========================================
+ Hits        10341    10416      +75     
- Misses        903      975      +72     
Impacted Files Coverage Δ
arviz/data/io_pymc3.py 92.19% <83.33%> (-0.25%) ⬇️
arviz/rcparams.py 85.45% <0.00%> (-7.68%) ⬇️
arviz/wrappers/base.py 18.36% <0.00%> (-2.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7651e0...cfdf83f. Read the comment docs.

@michaelosthege
Copy link
Contributor

@OriolAbril FYI I can't merge this.

Copy link
Contributor

@rpgoldman rpgoldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested one minor tweak, but it looks good to me other than that.

arviz/data/io_pymc3.py Outdated Show resolved Hide resolved
arviz/data/io_pymc3.py Outdated Show resolved Hide resolved
@canyon289
Copy link
Member

Should there be tests, even if theyre not run in CI

Copy link
Contributor

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. The CI failure looks unrelated to the changes from this PR

@michaelosthege
Copy link
Contributor

@OriolAbril can this be merged? The PR pymc-devs/pymc#4405 is blocked by the ArviZ release..

@AlexAndorra AlexAndorra merged commit 25ce6c4 into master Jan 15, 2021
@AlexAndorra AlexAndorra deleted the pre-release branch January 15, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants