-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes before releasing #1495
Fixes before releasing #1495
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1495 +/- ##
==========================================
- Coverage 91.96% 91.44% -0.53%
==========================================
Files 105 105
Lines 11244 11391 +147
==========================================
+ Hits 10341 10416 +75
- Misses 903 975 +72
Continue to review full report at Codecov.
|
@OriolAbril FYI I can't merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested one minor tweak, but it looks good to me other than that.
Should there be tests, even if theyre not run in CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. The CI failure looks unrelated to the changes from this PR
@OriolAbril can this be merged? The PR pymc-devs/pymc#4405 is blocked by the ArviZ release.. |
Description
Fixes
from_pymc3
compatibility with theano-pymc>=1.1 and allows going back to the original behaviour offrom_pymc3
withDensityDist
if desired.Tagging also @michaelosthege for review
Checklist
PR format?
section of the changelog?