Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix circular traceplot warnings and title #1517

Merged
merged 2 commits into from
Jan 23, 2021
Merged

Fix circular traceplot warnings and title #1517

merged 2 commits into from
Jan 23, 2021

Conversation

agustinaarroyuelo
Copy link
Contributor

@agustinaarroyuelo agustinaarroyuelo commented Jan 22, 2021

Description

When plotting circular variables with plot_trace the circular subplot title overlaps with the x tick labels. I also fixed repeating warnings derived from changing of tick locations.

On master:
trace_plot_master

This PR:
trace_plot

Checklist

  • Follows official PR format
  • Includes a sample plot to visually illustrate the changes (only for plot-related functions)
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #1517 (12f5e61) into master (90313a1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1517   +/-   ##
=======================================
  Coverage   91.76%   91.77%           
=======================================
  Files         105      105           
  Lines       11322    11330    +8     
=======================================
+ Hits        10390    10398    +8     
  Misses        932      932           
Impacted Files Coverage Δ
arviz/plots/backends/matplotlib/kdeplot.py 98.85% <100.00%> (+0.04%) ⬆️
arviz/plots/backends/matplotlib/traceplot.py 98.84% <100.00%> (+0.03%) ⬆️
arviz/data/io_pyro.py 97.35% <0.00%> (ø)
arviz/data/io_emcee.py 98.33% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90313a1...12f5e61. Read the comment docs.

@OriolAbril OriolAbril merged commit 4d8a65d into arviz-devs:master Jan 23, 2021
@agustinaarroyuelo agustinaarroyuelo deleted the warnings_fix branch January 27, 2021 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants