Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update io pystan #1585

Merged
merged 5 commits into from
Mar 4, 2021
Merged

Update io pystan #1585

merged 5 commits into from
Mar 4, 2021

Conversation

madhucharan
Copy link
Contributor

@madhucharan madhucharan commented Feb 26, 2021 •
edited
Loading

Description

Related to the issue #1514 , updated the file according to the schema convention

Checklist

  • Follows official PR format
  • Includes a sample plot to visually illustrate the changes (only for plot-related functions)
  • New features are properly documented (with an example if appropriate)?
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

@ahartikainen ahartikainen changed the title Update io pystanpy Update io pystan Feb 26, 2021
@codecov
Copy link

codecov bot commented Feb 26, 2021 •
edited
Loading

Codecov Report

Merging #1585 (a8dc57d) into main (4443da3) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1585      +/-   ##
==========================================
- Coverage   90.06%   90.05%   -0.02%     
==========================================
  Files         108      108              
  Lines       11600    11585      -15     
==========================================
- Hits        10448    10433      -15     
  Misses       1152     1152
Impacted Files Coverage Δ
arviz/data/io_pystan.py 96.01% <100.00%> (+<0.01%) ⬆️
arviz/labels.py 70.37% <0.00%> (-1.24%) ⬇️
arviz/plots/backends/bokeh/forestplot.py 95.13% <0.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4443da3...b97585a. Read the comment docs.

@madhucharan
Copy link
Contributor Author

madhucharan commented Feb 28, 2021 •
edited
Loading

Hi @OriolAbril , I think I have updated the three places, kindly let me know if there is any changes need to be made

ahartikainen
ahartikainen reviewed Feb 28, 2021
View reviewed changes
arviz/data/io_pystan.py Outdated Show resolved Hide resolved
arviz/data/io_pystan.py Outdated Show resolved Hide resolved
arviz/data/io_pystan.py Outdated Show resolved Hide resolved
arviz/data/io_pystan.py Outdated Show resolved Hide resolved
@madhucharan
Copy link
Contributor Author

@ahartikainen, Updated the changes according to the review.

@ahartikainen ahartikainen merged commit 5a00626 into arviz-devs:main Mar 4, 2021
utkarsh-maheshwari pushed a commit to utkarsh-maheshwari/arviz that referenced this pull request May 27, 2021
@madhucharan @utkarsh-maheshwari
Update io pystan (arviz-devs#1585)
9efc380 
* update io_pystan.py to follow schema convention

* refactor io_pystan.py

* update CHANGELOG.md

* remove lp from rename dict and refactor the function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahartikainen ahartikainen ahartikainen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madhucharan @ahartikainen