Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix io_cmdstanpy bugs #1595

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Fix io_cmdstanpy bugs #1595

merged 1 commit into from
Mar 4, 2021

Conversation

ahartikainen
Copy link
Contributor

@ahartikainen ahartikainen commented Mar 4, 2021

Fixes #1594

Small fixes

@ahartikainen ahartikainen changed the title fix small typos Fix io_cmdstanpy bugs Mar 4, 2021
@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #1595 (7e6c781) into main (43ceb17) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1595   +/-   ##
=======================================
  Coverage   90.05%   90.05%           
=======================================
  Files         108      108           
  Lines       11584    11584           
=======================================
  Hits        10432    10432           
  Misses       1152     1152           
Impacted Files Coverage Δ
arviz/data/io_cmdstanpy.py 60.99% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43ceb17...6563ffc. Read the comment docs.

@OriolAbril OriolAbril merged commit 4443da3 into main Mar 4, 2021
@OriolAbril OriolAbril deleted the bugfix/cmdstanpy branch March 4, 2021 17:58
@jburos
Copy link
Contributor

jburos commented Mar 4, 2021

Thanks for the quick turn-around on this, but I'm still seeing this bug on a fit from main.

I think this line is the culprit:

self.posterior,

@ahartikainen
Copy link
Contributor Author

Oh, yeah, missed one.

utkarsh-maheshwari pushed a commit to utkarsh-maheshwari/arviz that referenced this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

from_cmdstanpy uses posterior in place of prior when both provided
3 participants