-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infer dtypes for all Stan interfaces #1632
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, are you planning on adding tests? Maybe a test directly on infer_stan_dtypes
is enough. We can always create an issue to see if it gets done
Yes. (I have not tested these yet) |
42ae0e7
to
c44d325
Compare
Codecov Report
@@ Coverage Diff @@
## main #1632 +/- ##
==========================================
- Coverage 90.90% 90.86% -0.05%
==========================================
Files 108 108
Lines 11762 11818 +56
==========================================
+ Hits 10692 10738 +46
- Misses 1070 1080 +10
Continue to review full report at Codecov.
|
I also added dtypes option for from_pystan, so if users have complicated stan file, they still have possibility to define correct dtypes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I did a very good job with the changelog, either way, feel free to merge whenever
* reorganize stan dtypes extraction * add dtypes option for cmdstanpy * fix lint * lint * add simple tests * add dtypes for from_pystan * accept cmdstanpy.CmdStanModel object for dtypes * small fixes for cmdstanpy * dtypes test for pystan * run isort * fix lint * fix lint * fix typo * add to changelog * Change class loc * fix old array handling for dtype Co-authored-by: Oriol (ZBook) <oriol.abril.pla@gmail.com>
* reorganize stan dtypes extraction * add dtypes option for cmdstanpy * fix lint * lint * add simple tests * add dtypes for from_pystan * accept cmdstanpy.CmdStanModel object for dtypes * small fixes for cmdstanpy * dtypes test for pystan * run isort * fix lint * fix lint * fix typo * add to changelog * Change class loc * fix old array handling for dtype Co-authored-by: Oriol (ZBook) <oriol.abril.pla@gmail.com>
This reverts commit a4e873a.
Description
closes #1630
Checklist
Infer dtypes from model code (all interfaces) or use user given dictionary (cmdstanpy, cmdstan).