Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix legend labels in plot_ppc to reflect prior or posterior. #1967

Merged
merged 3 commits into from
Jan 20, 2022

Conversation

jedludlow
Copy link
Contributor

@jedludlow jedludlow commented Jan 19, 2022

Description

Legend labels were not tracking the selected group. In many instances
they were hardcoded to "Posterior ...".

Addresses #1966.

Checklist

  • Follows official PR format
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

Legend labels were not tracking the selected group. In many instances
they were hardcoded to "Posterior ...".
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #1967 (523f47a) into main (a67d81c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1967   +/-   ##
=======================================
  Coverage   90.83%   90.83%           
=======================================
  Files         114      114           
  Lines       12308    12308           
=======================================
  Hits        11180    11180           
  Misses       1128     1128           
Impacted Files Coverage Δ
arviz/plots/backends/matplotlib/ppcplot.py 97.61% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a67d81c...523f47a. Read the comment docs.

@OriolAbril
Copy link
Member

Thanks for the PR! Do you want to add it to the changelog?

@jedludlow
Copy link
Contributor Author

I added another commit which updates the CHANGELOG.

@OriolAbril OriolAbril merged commit 9d07469 into arviz-devs:main Jan 20, 2022
@jedludlow jedludlow deleted the fix-ppcplot-legends branch January 20, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants