-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Adding Bean Machine converter to Arviz #2107
Conversation
accdf15
to
a27ef9f
Compare
b230132
to
16a9f01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good so far, thanks!
Let me know if you need any help with tests or docs. I think ideally the docs would be more along the style of https://python.arviz.org/en/latest/getting_started/ConversionGuideEmcee.html but it can also be a single example temporarily.
Codecov Report
@@ Coverage Diff @@
## main #2107 +/- ##
==========================================
- Coverage 90.76% 90.61% -0.15%
==========================================
Files 117 118 +1
Lines 12497 12543 +46
==========================================
+ Hits 11343 11366 +23
- Misses 1154 1177 +23
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Co-authored-by: Oriol Abril-Pla <oriol.abril.pla@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think adding tests can be done later.
Description
This addresses #2106 by adding native support for Bean Machine into Arviz.
More tests and documentation are still needed.
Checklist
📚 Documentation preview 📚: https://arviz--2107.org.readthedocs.build/en/2107/