Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Adding Bean Machine converter to Arviz #2107

Merged
merged 4 commits into from
Oct 6, 2022

Conversation

zaxtax
Copy link
Contributor

@zaxtax zaxtax commented Sep 1, 2022

Description

This addresses #2106 by adding native support for Bean Machine into Arviz.

More tests and documentation are still needed.

Checklist

  • Follows official PR format
  • New features are properly documented (with an example if appropriate)?
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

📚 Documentation preview 📚: https://arviz--2107.org.readthedocs.build/en/2107/

Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good so far, thanks!

Let me know if you need any help with tests or docs. I think ideally the docs would be more along the style of https://python.arviz.org/en/latest/getting_started/ConversionGuideEmcee.html but it can also be a single example temporarily.

doc/source/api/data.rst Outdated Show resolved Hide resolved
arviz/data/io_beanmachine.py Outdated Show resolved Hide resolved
arviz/data/io_beanmachine.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #2107 (1454dce) into main (aa247e2) will decrease coverage by 0.14%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##             main    #2107      +/-   ##
==========================================
- Coverage   90.76%   90.61%   -0.15%     
==========================================
  Files         117      118       +1     
  Lines       12497    12543      +46     
==========================================
+ Hits        11343    11366      +23     
- Misses       1154     1177      +23     
Impacted Files Coverage Δ
arviz/data/io_beanmachine.py 39.47% <39.47%> (ø)
arviz/data/converters.py 67.12% <66.66%> (-0.02%) ⬇️
arviz/data/__init__.py 100.00% <100.00%> (ø)
arviz/plots/parallelplot.py 97.77% <0.00%> (ø)
arviz/data/io_numpyro.py 93.98% <0.00%> (+0.18%) ⬆️
arviz/plots/energyplot.py 88.88% <0.00%> (+5.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zaxtax
Copy link
Contributor Author

zaxtax commented Sep 8, 2022 via email

ahartikainen and others added 2 commits October 6, 2022 09:49
Co-authored-by: Oriol Abril-Pla <oriol.abril.pla@gmail.com>
Copy link
Contributor

@ahartikainen ahartikainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think adding tests can be done later.

@ahartikainen ahartikainen merged commit e1903c0 into arviz-devs:main Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants