Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix handling of default dims #2138

Merged
merged 4 commits into from
Oct 16, 2022

Conversation

OriolAbril
Copy link
Member

@OriolAbril OriolAbril commented Oct 12, 2022

Description

We have the concept of default_dims in dict_to_dataset and related functions,
which are dimensions that come at the beginning and can be omitted from the
dims list but they can also be there. This fixes a bug for the case
where the default_dims are present in the dims list (which is necessary
when the default dims are not chain and draw).

Checklist

  • Does the PR follow official PR format?
  • Does the PR include new or updated tests to prevent issue recurrence (using pytest fixture pattern)?
  • Is the code style correct (follows pylint and black guidelines)?
  • Is the fix listed in the Maintenance and fixes section of the changelog?

📚 Documentation preview 📚: https://arviz--2138.org.readthedocs.build/en/2138/

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #2138 (7c26abf) into main (b2503b5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2138   +/-   ##
=======================================
  Coverage   90.73%   90.73%           
=======================================
  Files         118      118           
  Lines       12566    12567    +1     
=======================================
+ Hits        11402    11403    +1     
  Misses       1164     1164           
Impacted Files Coverage Δ
arviz/data/base.py 98.21% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@OriolAbril OriolAbril added this to the v0.13 milestone Oct 13, 2022
@ahartikainen ahartikainen merged commit 5408e3d into arviz-devs:main Oct 16, 2022
@OriolAbril OriolAbril deleted the default_dims_handling branch October 16, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants