Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor plot_bf #2152

Merged
merged 3 commits into from
Nov 4, 2022
Merged

Refactor plot_bf #2152

merged 3 commits into from
Nov 4, 2022

Conversation

aloctavodia
Copy link
Contributor

@aloctavodia aloctavodia commented Nov 2, 2022

Description

This refactor plot_bf mainly to separate the ploting code from the computation code as with other plots

Additionally, this adds a few arguments so it becomes more similar to existing plots.

Finally, this PR adds support for discrete variables.

Checklist

  • Follows official PR format
  • Includes a sample plot to visually illustrate the changes (only for plot-related functions)
  • New features are properly documented (with an example if appropriate)?
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

BF_disc
BF_cont

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #2152 (241d586) into main (8c819d2) will increase coverage by 11.19%.
The diff coverage is 83.82%.

@@             Coverage Diff             @@
##             main    #2152       +/-   ##
===========================================
+ Coverage   79.50%   90.70%   +11.19%     
===========================================
  Files         119      120        +1     
  Lines       12616    12647       +31     
===========================================
+ Hits        10030    11471     +1441     
+ Misses       2586     1176     -1410     
Impacted Files Coverage Δ
arviz/plots/bfplot.py 77.41% <77.41%> (ø)
arviz/plots/backends/matplotlib/bfplot.py 88.88% <88.88%> (ø)
arviz/plots/__init__.py 100.00% <100.00%> (ø)
arviz/utils.py 88.23% <0.00%> (+0.32%) ⬆️
arviz/plots/plot_utils.py 90.00% <0.00%> (+0.45%) ⬆️
arviz/data/base.py 98.21% <0.00%> (+5.95%) ⬆️
arviz/data/io_pymc3.py 73.33% <0.00%> (+6.66%) ⬆️
arviz/data/io_cmdstan.py 89.42% <0.00%> (+40.08%) ⬆️
arviz/data/io_numpyro.py 93.98% <0.00%> (+67.66%) ⬆️
arviz/data/io_pyro.py 96.89% <0.00%> (+68.21%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aloctavodia aloctavodia marked this pull request as ready for review November 3, 2022 16:35
@aloctavodia aloctavodia changed the title [WIP] Refactor plot_bf Refactor plot_bf Nov 3, 2022
@orduek
Copy link
Contributor

orduek commented Nov 4, 2022

Thank you Osvaldo!
Let me know if I can help in any way.

@aloctavodia aloctavodia merged commit 2d88638 into main Nov 4, 2022
@aloctavodia aloctavodia deleted the plotbf_refactor branch November 4, 2022 10:33
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Mar 22, 2023
https://build.opensuse.org/request/show/1073712
by user dgarcia + dimstar_suse
- skip python 3.11 and python 3.8 because some dependencies doesn't
  support that python versions
- Update to 0.15.1
  - Fix memory usage and improve efficiency in `from_emcee`
    ([2215](arviz-devs/arviz#2215))
  - Lower pandas version needed
    ([2217](arviz-devs/arviz#2217))
- 0.15.0
  - Adds Savage-Dickey density ratio plot for Bayes factor
    approximation.
    ([2037](arviz-devs/arviz#2037),
    [2152](arviz-devs/arviz#2152))
  - Add `CmdStanPySamplingWrapper` and `PyMCSamplingWrapper` classes
    ([2158](arviz-devs/arviz#2158))
  - Changed dependency on netcdf4-python to h5netcdf
    ([2122](arviz-devs/arviz#2122))
  - Fix `reloo` outdate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants