Fix plot_lm and _z_scale for scipy 1.10 #2186
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
plot_lm used np.tile on the plotter lists which contain 4 elements, a string, two dicts and an
array, somehow coercing all this into a numpy array while doing some repetition of elements
to match x and y values. This always rose many warnings, it now breaks the code and therefore the
tests.
This PR updates this to use lists and itertools all the way to perform the same type of repetitions,
no array features were really used so I think it makes more sense to use lists.
I have also updated the code in _z_scale to work with scipy 1.10 and higher as the nan policy in rankdata has changed.
Checklist
It does not, tests are already broken due to this so it can't go back.
section of the changelog?
📚 Documentation preview 📚: https://arviz--2186.org.readthedocs.build/en/2186/