Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue in labeller #2200

Merged
merged 2 commits into from
Feb 9, 2023
Merged

fix issue in labeller #2200

merged 2 commits into from
Feb 9, 2023

Conversation

OriolAbril
Copy link
Member

@OriolAbril OriolAbril commented Jan 28, 2023

Description

When combining with NoVarLabeller or NoModelLabeller there were some stray
nones being printed. This should fix the issue.

Checklist

  • Does the PR follow official PR format?
  • Is the code style correct (follows pylint and black guidelines)?
  • Is the fix listed in the Maintenance and fixes section of the changelog?

📚 Documentation preview 📚: https://arviz--2200.org.readthedocs.build/en/2200/

@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

Merging #2200 (b06f4a5) into main (4fc5000) will decrease coverage by 0.01%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main    #2200      +/-   ##
==========================================
- Coverage   89.91%   89.91%   -0.01%     
==========================================
  Files         119      119              
  Lines       12419    12421       +2     
==========================================
+ Hits        11167    11168       +1     
- Misses       1252     1253       +1     
Impacted Files Coverage Δ
arviz/labels.py 93.50% <80.00%> (-1.17%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@OriolAbril OriolAbril merged commit 3514017 into arviz-devs:main Feb 9, 2023
@OriolAbril OriolAbril deleted the labeller branch February 9, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant