Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KDE: Display quantiles #479

Merged
merged 5 commits into from
Jan 8, 2019
Merged

KDE: Display quantiles #479

merged 5 commits into from
Jan 8, 2019

Conversation

aloctavodia
Copy link
Contributor

This add the option to get a KDE segmented into quartiles (or more general quantiles). There are still a few things to fix and improve

gauss_q

expo_q

@aloctavodia
Copy link
Contributor Author

Should we allow for quantiles other than quartiles? If so how the user should pass those options?

  • predefined strings like "quartiles", "quintiles", "deciles"
  • list of floats like [25, 50, 75]
  • a mix of both?
  • other

@ahartikainen
Copy link
Contributor

List of numbers between 0 and 100. Or quantiles => list of numbers between 0 and 1.

Also what algorithm should we use for quantiles etc? Data or kde results?

@aloctavodia
Copy link
Contributor Author

Good question. I guess using the estimated density is more consistent.

@ahartikainen
Copy link
Contributor

Also, would there be any potential to define ... "symmetric" quantile, e.g. distribution which is constrained and MAP is on one of the constrain?

E.g. 1-tail / 2-tail / negative 1-tail

@aloctavodia aloctavodia changed the title [WIP] display quartiles KDE: Display quantiles Jan 2, 2019
@aloctavodia
Copy link
Contributor Author

Not sure I truly understand what these "symmetric" quantiles are

@ahartikainen
Copy link
Contributor

True, I probably don't understand them either.

I think it similar if we split data based on the density (starting from top, moving horizontal line down until q-quantile of the density is inside the density limits...

@aloctavodia
Copy link
Contributor Author

In that case I vote for leaving the "symmetric" quantiles for another PR.

@ahartikainen
Copy link
Contributor

Good choice

@canyon289
Copy link
Member

May I ask for a test? I can write one if you're strapped for time

@aloctavodia
Copy link
Contributor Author

Sure! I can add a test, but not until next Tuesday. So if you want to add it sooner than that, please go ahead.

@canyon289
Copy link
Member

LGTM

@aloctavodia
Copy link
Contributor Author

@ahartikainen are you also OK with this?

@ahartikainen
Copy link
Contributor

Lgtm

@aloctavodia aloctavodia merged commit 0b14c03 into master Jan 8, 2019
@aloctavodia aloctavodia deleted the kde_quartiles branch January 8, 2019 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants