Add InferenceData tutorial in header #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, (see comment for table) |
ahartikainen
reviewed
Jan 5, 2019
| " <li>xarray.Dataset</li>\n", | ||
| " <li>arviz.InferenceData</li>\n", | ||
| " <li>netCDF</li>\n", | ||
| "</ul> \n", |
There was a problem hiding this comment.
Should these be hidden? If I check these with view, I can see them
<ul ...
</ul>
Maybe if they are translated to HTML they are hidden
There was a problem hiding this comment.
Aw shoot that's annoying. They seem to get hidden when Sphinx renders them, but not github apparently. I'll make another fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will add InferenceData tutorial in header to meet paper review feedback.
In making this documentation I tried first creating a Tutorial page like Seaborn
https://seaborn.pydata.org/tutorial.html
However it seems getting to this will require more work. Seaborn doesn't use the nbconvert plugin, instead providing its own Makefiles and scripts that convert the notebooks to .rst and .html at the appropriate times
https://github.com/mwaskom/seaborn/blob/master/doc/Makefile
https://github.com/mwaskom/seaborn/tree/master/doc/tools
https://github.com/mwaskom/seaborn/blob/master/doc/tutorial/Makefile
I think it would be great to implement this eventually, but for now just want to get the existing tutorial visible for the paper review