add stable logsumexp #522
Merged
add stable logsumexp #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahartikainen
force-pushed
the
bugfix/logsumexp
branch
from
6f7bbe4
to
a091be9
Compare
ahartikainen
force-pushed
the
bugfix/logsumexp
branch
from
6c6dea2
to
de100a7
Compare
|
LGTM! |
|
I will merge this now. It's tests against scipy implementation (our function is faster), and it returns dtypes correctly for floats. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements stable logsumexp when
b>0also can use b_inv which is better than 1/x when x is large.