Fix nan handling and fix n_eff to ess #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually we return dataframe by default, but still we have an option to return xarray, so I think we should follow what xarray does. |
ahartikainen
changed the title
|
LGTM! |
canyon289
reviewed
Jan 28, 2019
| @@ -29,7 +29,7 @@ def plot_forest( | |||
| credible_interval=0.94, | |||
| rope=None, | |||
| quartiles=True, | |||
| eff_n=False, | |||
|
LGTM, I don't know what is going on with coveralls, it seems to be including linter, It should only be including unit test containers |
|
Yeah, it fails sometimes. I will restart one of the builds (e.g. PR) and let's see how that goes. (Inside coveralls is shows 100%) Linter one tests |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes ess to return float if NaN is seen.
Until there exists a way to return integer dtype with NaN, this is the best option.
Let's follow how xarray evolves with this issue. pydata/xarray#1194
Also I noticed that there was many
n_effleft so I changed them to ess.