fix kde scaling #582
Merged
fix kde scaling #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
I tested this with locally, and everything looks ok. The integral is maybe 1% off from the 1, but given that there are much bigger uncertainties in KDE estimation than that error and we are not even suggesting that there is no probability mass outside the estimated area, I will merge this in. |
Ban-zee
pushed a commit
to Ban-zee/arviz
that referenced
this pull request
Feb 9, 2019
* manual limits for kde * fix norm constant, check limits, add tests * remove xmin, xmax args from plot_kde
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #581. Also add tests and add
xminandxmaxarguments to_fast_kde. After internal discussion we decided not to add xmin-xmax arguments toplot_kde.