Add dictionary option for stat_funcs in summary #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canyon289
reviewed
Feb 9, 2019
| stat_funcs : None or list | ||
| A list of functions used to calculate statistics. By default, the mean, standard deviation, | ||
| simulation standard error, and highest posterior density intervals are included. | ||
| stat_funcs : dict |
There was a problem hiding this comment.
This can be a dict, or an iter right? It looks like if you pass a list or tuple you'll still hit this line
There was a problem hiding this comment.
Oh yes, dict or sequence
| def test_summary_stat_func(centered_eight): | ||
| assert summary(centered_eight, stat_funcs=[np.var]) is not None | ||
| @pytest.mark.parametrize( | ||
| "stat_funcs", [[np.var], {"var": np.var, "var2": lambda x: np.var(x) ** 2}] |
There was a problem hiding this comment.
In regards to the comment above this test seems to pass a list and still functions.
There was a problem hiding this comment.
Yes, I wanted to keep original structure
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables one to use a dictionary in stat_funcs. This way the user can name the functions and use lambda with the correct name.