Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation example for combining InferenceData (#552) and also solving the issue of creaton of empty file for better behaviour with inference data(#486) #590

Closed
wants to merge 2 commits into from

Conversation

Shashankjain12
Copy link
Contributor

Added example in the docstring as per the issue number #552

@Shashankjain12
Copy link
Contributor Author

Why travis-ci is failing to build as my all test cases are solved except python3.6 lint?

@Shashankjain12
Copy link
Contributor Author

Better behavior with empty InferenceData #486

@Shashankjain12 Shashankjain12 changed the title Added documentation example for combining InferenceData (#552) Added documentation example for combining InferenceData (#552) and also solving the issue of creaton of empty file for better behaviour with inference data(#486) Feb 17, 2019
@canyon289
Copy link
Member

canyon289 commented Feb 17, 2019

@Shashankjain12 I hate to be the bearer of bad news

  1. This issue is already in progress here, in good faith I can't accept this PR because someone else is already putting effort into it. Before taking on an issue please double check if someone else is working on it
  2. Try and do one PR per issue. It makes it much easier to sort things out, large PRs are hard to manage and comment on

My suggestion would be to close this PR and just add documentation for combining inference data

#577

@Shashankjain12
Copy link
Contributor Author

Ok sure I will close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants