Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Import coords and dims from pymc3 #757

Closed
wants to merge 1 commit into from

Conversation

aseyboldt
Copy link
Contributor

*Depends on pymc-devs/pymc#3551 *
This allows arviz to read dims and coords from pymc3 when they are defined.

@canyon289
Copy link
Member

This looks great! Is it still in WIP and or do we need to add tests?

@ahartikainen
Copy link
Contributor

Is this ready (I would like to get this in for the next release)

@canyon289
Copy link
Member

Checking in on old PRs. Any possibility of bringing this over the line or should we close?

@OriolAbril
Copy link
Member

I think this depends on a PR to PyMC3 that just got reactivated. We should probably revisit after pymc-devs/pymc#3551 has been merged and see if it would require any release magic/monkeypatching... cc @AlexAndorra @michaelosthege

If interesting, I can rebase the PR (I am quite up to date with changes in io_pymc3 and should not break any of the new changes while rebasing)

@AlexAndorra
Copy link
Contributor

Indeed, I'm planning to review the PyMC PR in the coming days -- will keep you posted 😉
We're trying to merge the PR to have it in 3.9, so it should be resolved quite quickly.

@michaelosthege
Copy link
Contributor

I resolved the conflicts in #1228. Testing with the PyMC3 PR branch now…
This PR can be closed.

@canyon289 canyon289 closed this Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants