Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple setup for linux #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Simple setup for linux #4

wants to merge 1 commit into from

Conversation

fejese
Copy link
Contributor

@fejese fejese commented Jul 9, 2020

Using the cards from https://github.com/jminuscula/dixit-online which in turns uses cards from pinterest. That's fine I guess?

@arvoelke
Copy link
Owner

arvoelke commented Jul 9, 2020

Interesting. Hadn't heard of this other Dixit implementation. Are there reasons to prefer this over the other? It looks like mine was earlier, but this other one is more popular? I'm not sure how I feel about perpetuating the infringement of copyright of the original artwork even if it was scraped from Pinterest. Also not clear to me how robust / general the script is for most environments. For instance, I think it would be more robust to do the download within the server code itself, e.g., by downloading and unzipping https://github.com/jminuscula/dixit-online/archive/master.zip. I think I'll leave this here for now so that others can discover the script and this other Dixit repo if they so choose, and maybe there will be a clearer option in the future for some sort of open-source repository of cards. Likewise, adding a setup.py and releasing this on PyPI might be preferable versus requiring users to have git and run an install script.

@arvoelke
Copy link
Owner

By the way, I decided to go ahead and release this on PyPI (#7). Installing and running this should now be as simple as:

pip install dixit
dixit

There's still plenty to do in making this fully-featured, user-friendly, configurable, and accessible in terms of obtaining card decks. Thanks again for your help with this.

@fejese
Copy link
Contributor Author

fejese commented Jul 10, 2020

so honestly, I didn't mean to send this as a PR yet, only to my own fork, but figured I might as well get your thoughts on it :)

regarding the other implementation the problem is that while it looks more sophisticated in some ways, the frontend is just not implemented yet :)

so totally fine leaving the PR hanging, I might go check if we can do this to better handle copyright and all

@fejese fejese force-pushed the setup branch 2 times, most recently from 7d820b3 to 9141f43 Compare July 10, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants