Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --exact flag to skip adding main and HEAD in smartlog #1241

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

adzenith
Copy link
Contributor

@adzenith adzenith commented Feb 14, 2024

As discussed in #1240, I would like to be able to present smartlogs without including main or HEAD. After discussion in this PR, the flag is named --exact.

I've added tests and everything appears to be green. Let me know your thoughts!

@adzenith
Copy link
Contributor Author

I'm not sure how to repro that nix failure. I can't seem to get anything to fail locally.

@claytonrcarter
Copy link
Collaborator

open to suggestions for a different flag if you have a better idea

I don't know if it's better, but I was wondering about --exact because you're asking for the log of the exact revset you're passing in (and nothing else), and it has symmetry with the --exact flag already in use on git-branchless move.

Copy link
Owner

@arxanas arxanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! The build failure is unrelated and should be resolved in #1243.

git-branchless-opts/src/lib.rs Outdated Show resolved Hide resolved
git-branchless-smartlog/src/lib.rs Outdated Show resolved Hide resolved
git-branchless-smartlog/tests/test_smartlog.rs Outdated Show resolved Hide resolved
@adzenith adzenith changed the title Add a flag to skip adding main and HEAD in smartlog Add --exact flag to skip adding main and HEAD in smartlog Feb 19, 2024
Copy link
Owner

@arxanas arxanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@arxanas arxanas merged commit 726f609 into arxanas:master Feb 19, 2024
13 checks passed
@adzenith adzenith deleted the smartlog-detached branch February 20, 2024 05:43
@adzenith
Copy link
Contributor Author

Awesome! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants