Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(submit): print submit status for each commit individually #1311

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

feat(submit): print submit status for each commit individually #1311

wants to merge 3 commits into from
+565 −329

Commits on Aug 9, 2024

  1. feat(submit:phabricator): do not abort entire process on failure 

    Currently, `git submit` for Phabricator will abort the entire operation if any commit fails to be submitted. This means that if `arc diff` succeeds on one commit and then fails on its child, the entire operation is aborted. However, the first `arc diff` had side effects, so the user gets diffs uploaded to Phabricator that are not reflected locally. Instead, we should confirm any passing commits and abort after we get a failing commit. This commit updates the Phabricator forge to handle the error case better and not produce garbage commits on Phabricator.
    @arxanas
    arxanas committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    14b111e View commit details
    Browse the repository at this point in the history

  2. refactor(submit): Forge::update returns UpdateStatuses 

    For uniformity with `CreateStatus`.
    @arxanas
    arxanas committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    70b9a36 View commit details
    Browse the repository at this point in the history

  3. feat(submit): print submit status for each commit individually

    @arxanas
    arxanas committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    1c2504c View commit details
    Browse the repository at this point in the history