Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split CI workflows up for the OS badges #24

Merged
merged 3 commits into from
Jun 24, 2021
Merged

Conversation

waych
Copy link
Contributor

@waych waych commented Jun 23, 2021

Allows the reader to see that the project's CI supports their platform
at a glance.

Badge links format looks to have changed. Tested by pointing temporarily
at my own repo to see the badges in the rendered README.md.

Allows the reader to see that the project's CI supports their platform
at a glance.

Badge links format looks to have changed. Tested by pointing temporarily
at my own repo to see the badges in the README.md.
Copy link
Owner

@arxanas arxanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, thanks for doing this.

.github/workflows/fmt.yml Outdated Show resolved Hide resolved
.github/workflows/macos.yml Show resolved Hide resolved
@waych waych requested a review from arxanas June 24, 2021 02:31
Copy link
Owner

@arxanas arxanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We get 2000 free minutes per month. There's a 1x multiplier for Linux, 2x for Windows, and 10x for macOS. So the typical 3-minute build on Linux would count for 30 minutes on macOS!

@arxanas arxanas merged commit 6ff9f7a into arxanas:master Jun 24, 2021
@arxanas
Copy link
Owner

arxanas commented Jun 25, 2021

Hm, maybe I was mistaken, and the repository gets unlimited minutes since it's not private!

@waych
Copy link
Contributor Author

waych commented Jun 25, 2021

Sweet. In that case I'll send a PR to schedule the macOS everyday so its still out of the way but gets a better signal in case something regresses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants