More Phabricator forge for git submit
#866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arxanas
force-pushed
the
arxanas/submit2
branch
7 times, most recently
from
fd5d9d4 to
b3bd6b4
Compare
…`post-commit` hook If two commits aren't topologically related and then we simultaneously ask the `Dag` to process them, then it's not guaranteed which order they'll be visited. Then, later in testing, when we try to topologically sort a set of commits, the order of these two commits is non-deterministic. In `hide.rs`, we get around this by using the `sorted_commit_set` function. However, this function isn't actually a sound sorting function (see comments internal to the function). In a future commit, we changed it to use `Dag::sort` instead, but this exposed the non-determinism above. To fix this, we process the commit during the `post-commit` hook, to ensure that the commits are deterministically ordered (assuming that the commits were originally made in a deterministic order).
It seems that `sort` returns commits in the order of children first, which is the opposite of what we want in all cases. This commit fixes our wrapper around `.sort` to reverse the resulting commit list.
… executable is out of date
This is a long-outstanding bug: commits created during a rebase that is later aborted remain in the smartlog. To fix this, we defer registering the commits until the rebase has concluded.
The interface of `run_tests` was unsafe to use previously, since it could clobber working copy changes, and it would leave the commit graph in a semi-broken state (with rewritten commits showing in the smartlog).
…opy changes Without this change, in addition to printing the normal helpful message, having uncommitted working copy changes would raise an unhandled error.
…de>` For consistency with the other interface methods. We'll replace `()` with real data later.
It currently indiscriminately runs `arc diff`, even if the commits have not changed, which is suboptimal.
arxanas
force-pushed
the
arxanas/submit2
branch
from
b3bd6b4 to
bcc879d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.