Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: render no-changes UI message #11

Merged
merged 2 commits into from
Dec 23, 2023
Merged

feat: render no-changes UI message #11

merged 2 commits into from
Dec 23, 2023

Conversation

arxanas
Copy link
Owner

@arxanas arxanas commented Dec 17, 2023

No description provided.

@arxanas arxanas force-pushed the arxanas/no-changes branch 2 times, most recently from 5717115 to 7c5effa Compare December 17, 2023 23:23
@arxanas arxanas marked this pull request as ready for review December 18, 2023 00:31
If the UI has no changes to show, then there will be no selected item as well, so we need to be able to represent this case.
It's a little confusing when the calling program provides no changes in the UI, which is probably a bug in the caller, but worth explaining explicitly anyways.
@arxanas arxanas merged commit 7bb6919 into main Dec 23, 2023
2 checks passed
@arxanas arxanas deleted the arxanas/no-changes branch December 23, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant