Use destroy_at to call explicit destructor in make_inner_n #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m/colugomusic/immer into fix-msvc-explicit-destructor-call
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #263 +/- ##
=======================================
Coverage 90.50% 90.51%
=======================================
Files 119 119
Lines 12121 12122 +1
=======================================
+ Hits 10970 10972 +2
+ Misses 1151 1150 -1
|
arximboldi
approved these changes
May 25, 2023
Comment on lines
+23
to
+26
| // For C++14 support. | ||
| // Calling the destructor inline breaks MSVC in some obscure | ||
| // corner cases. | ||
| template <typename T> constexpr void destroy_at(T* p) { p->~T(); } |
There was a problem hiding this comment.
So just having this is enough to make MSVC work? 🤣 What a joke of a compiler...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the MSVC madness I was experiencing before. This compiles in both C++17 and C++20 mode.