Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Change AST types from class type to instance #151

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

xmnlab
Copy link
Contributor

@xmnlab xmnlab commented Nov 27, 2024

Pull Request description

This PR aims to normalize the usage of AST Types for data types, moving from using Class as values to the instance of the classes.

Additionally, this PR fixes the usage of some data types classes and tests.

How to test these changes

  • ...

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more
    complexity.
  • New and old tests passed locally.

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved .

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@xmnlab xmnlab marked this pull request as draft November 28, 2024 01:15
@xmnlab xmnlab marked this pull request as ready for review November 28, 2024 02:07
@xmnlab xmnlab merged commit 1997e75 into arxlang:main Nov 28, 2024
14 checks passed
@xmnlab xmnlab deleted the improve-types branch November 28, 2024 02:09
Copy link

🎉 This PR is included in version 0.16.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@xmnlab xmnlab mentioned this pull request Dec 2, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant