macOS improvements and general warnings fixed #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ices, giving better error output and fixing the "Resource busy" error.
|
According to #38 it's not really working. What do you suggest @tempelmann ? Should I just reject this pull request, or this could maybe be helpful later and merging to the macosx branch is useful? |
|
My pull req still fixes some issues, so accepting it would still help others who might try to take this further. |
|
Thanks @tempelmann, merged into the macosx branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit fixes some warnings I get with gcc on macOS in several shared source files. I took care to not break this for Linux & Win but did test this. Let me know if it causes problems.
The other commits improve the mac specific code, and add an Xcode project and explanations for easier development and debugging on a Mac.