Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify cpp checker bundle example and update cpp baselib #199

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

hoangtungdinh
Copy link
Collaborator

Description

This PR simplifies the C++ checker bundle example and makes it output proper rule UID. This is to prepare for replacing the C++ text report with the Python text report, in which stricter enforcement of rule UID format is required. See #191 .

Also remove methods in the C++ baselib that allow users to create Issues without Rule UID.

Note that, the C++ baselib still doesn't have strict enforcement for rule UID format and for rule registration.

Main changes

  1. Remove the option --default_config from the C++ example checker bundle.
  2. Remove the option to call the C++ example checker bundle directly with a .xodr file as input. Now, the C++ checker bundle only accepts a configuration file as input.
  3. Update the test configuration for the C++ example checker bundle.
  4. Set proper rule UID for checkers and issues in the C++ example checker bundle.
  5. Remove methods that allow users to create issues without a proper rule UID in the C++ baselib.

How was the PR tested?

  1. Unit-test.
  2. Runtime test using the test pipeline in the Python qc_framework.
  3. Load the generated .xqar result from the C++ checker bundle using qc_baselib. The results can be loaded successfully.

@andreaskern74 andreaskern74 added the isState:ForCCBReview CCB will review it and change the status to ReadyForMerge if everything is ok label Oct 11, 2024
@andreaskern74
Copy link
Collaborator

Added CCB label, because target is main

Copy link
Collaborator

@andreaskern74 andreaskern74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do much more, make it nicer, .... but yes, not as part of this PR for preparing the release.

Signed-off-by: hoangtungdinh <11166240+hoangtungdinh@users.noreply.github.com>
@andreaskern74 andreaskern74 added isState:ReadyForMerge An issue that has been integrated and is assigned to the workflow manager and removed isState:ForCCBReview CCB will review it and change the status to ReadyForMerge if everything is ok labels Oct 24, 2024
@andreaskern74 andreaskern74 merged commit 232f0ee into main Oct 24, 2024
4 checks passed
@andreaskern74 andreaskern74 deleted the tung/example-bundle branch October 24, 2024 10:04
@andreaskern74 andreaskern74 removed the isState:ReadyForMerge An issue that has been integrated and is assigned to the workflow manager label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants