Add file location from XML elements to the issues in checks #124
Conversation
Signed-off-by: Johannes Wenninger <johannes.wenninger@lcm.at>
Signed-off-by: Johannes Wenninger <johannes.wenninger@lcm.at>
|
@MatteoRagni / @pmai / @hoangtungdinh : What do you think about this contribution? See also discussion in asam-ev/qc-baselib-py#51 . This could be somehow wrapped in an own function, because it's always the same. But it general I like to add the filelocation directly in the checker library, because in Python the information is directly available. No need to wait for the call to the Result Pooling if only one checker library is used. |
andreaskern74
added
the
isState:ForCCBReview
There was a problem hiding this comment.
Hi @johannesWen, @andreaskern74,
Thank you for your contribution, @johannesWen. I think the change looks great!
Ideally, we can change qc-baselib-py to add a function add_locations, which adds both xpath and file location based on lxml elements. It is also related to this issue.
But I think this PR is good to be merged already.
|
Adapted the description and the subject to the implementation. @johannesWen : We need three approvals from CCB members to merge the PR. Maybe it takes a little bit longer due the holidays. Let's see.... |
andreaskern74
changed the title
|
@andreaskern74 |
I would agree that this is something that should ideally be handled in baseline going forward, either as suggested with a common helper function, or by having a sub-class relationship that makes xml locations optionally also have file location info. But as @hoangtungdinh says, in the interim it makes sense to merge this PR from my side. |
Description
Added also the file location of the XML elements to issues, so that result file contains this information without calling the result pooling before.
Belongs to discussion in qc-baselib-py PR: asam-ev/qc-baselib-py#51
How was the PR tested?