Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade lrucache #36

Closed
asamuzaK opened this issue Jan 9, 2025 · 14 comments
Closed

Downgrade lrucache #36

asamuzaK opened this issue Jan 9, 2025 · 14 comments

Comments

@asamuzaK
Copy link
Owner

asamuzaK commented Jan 9, 2025

see jsdom/cssstyle#181

@asamuzaK
Copy link
Owner Author

asamuzaK commented Jan 10, 2025

Also add exports.default in package.json for fallback.
Ref https://nodejs.org/api/packages.html#conditional-exports

asamuzaK added a commit that referenced this issue Jan 10, 2025
Fix #36
* Downgrade lru-cache
* Add exports.default
* Remove exports.browser
* Remove bundle-browser
@asamuzaK
Copy link
Owner Author

@Evertvdw @heidfeld @Bladesheng @consultor5aluiz
cc @domenic

Hi, all.

Pre-published a beta version for testing.
Add the following fields to package.json, run tests and/or anything else you want to check, and see if it works as expected.

npm:

"overrides": {
  "@asamuzakjp/css-color": "^2.8.3-b.1"
},

yarn:

"resolutions": {
  "@asamuzakjp/css-color": "^2.8.3-b.1"
},

@Bladesheng
Copy link

or pnpm:

"pnpm": {
  "overrides": {
    "@asamuzakjp/css-color": "^2.8.3-b.1"
  }
}

Works great 👍. I'm no longer getting the original error

@asamuzaK
Copy link
Owner Author

And please let me know the results.
Without feedback, I cannot merge and release a stable.

@asamuzaK
Copy link
Owner Author

Works great 👍. I'm no longer getting the jsdom/cssstyle#181 (comment)

Thanks for your contribution

@asamuzaK
Copy link
Owner Author

asamuzaK commented Jan 10, 2025

Checklist

  • node version range (lru-cache version issue)
  • jest
  • vitest

@Evertvdw
Copy link

@asamuzaK Yes I can confirm that with that beta version the error I initially reported no longer occurs.

@drichar
Copy link

drichar commented Jan 10, 2025

@asamuzaK I can also confirm the beta resolves the issue reported in jsdom/cssstyle#181 for me in Vitest

@asamuzaK
Copy link
Owner Author

@Evertvdw @drichar
Thanks for your contribution.

Only jest left.

@asamuzaK
Copy link
Owner Author

Someone please check with jest?

@asamuzaK
Copy link
Owner Author

@Evertvdw @heidfeld @Bladesheng @consultor5aluiz @NicoPennec @crutchcorn @aryaemami59

Hi, all again.
Sorry for taking time to fix this issue.

Released a new beta version for testing.
Changes:

  • Added types in each exports
  • Renamed bundled cjs package from css-color.min.cjs to css-color.cjs
  • Dependencies are not included anymore in bundled package

Add the following fields to package.json, run tests and/or anything else you want to check, and see if it works as expected.

npm:

"overrides": {
  "@asamuzakjp/css-color": "^2.8.3-b.2"
}

yarn:

"resolutions": {
  "@asamuzakjp/css-color": "^2.8.3-b.2"
}

pnpm:

"pnpm": {
  "overrides": {
    "@asamuzakjp/css-color": "^2.8.3-b.2"
  }
}

And please, please someone confirm with jest.
I need your feedback to move forward.

Thanks.

@heidfeld
Copy link

Works fine in our case with "@asamuzakjp/css-color": "^2.8.3-b.2".

@asamuzaK
Copy link
Owner Author

Released v3.0.0
Thanks all for your contribution and patience.
And many many thanks to @crutchcorn

@asamuzaK
Copy link
Owner Author

asamuzaK commented Jan 15, 2025

Released v2.8.3 for backport.
https://www.npmjs.com/package/@asamuzakjp/css-color/v/2.8.3
It is the same as v3.0.0, only the version is different.

I have already submitted a PR to cssstyle, but if you really can't wait until jsdom and cssstyle to be updated, you can uninstall jsdom and reinstall it, then v2.8.3 will be applied.
However, do so at your own risk.

ls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants