Fix run_sad #1
Open
Fix run_sad #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This problem is related to this issue: yarnpkg/yarn#685 The problem is that yarn copies the entire folder from `./tripetto-block-text/` to `./app/node_modules/tripetto-block-text`. This also includes the `node_modules` folder in `./tripetto-block-text/node_modules`. This folder also contains the `tripetto` package. So now, the text block will use this locale instance of Tripetto to register the block instead of the one used by the app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This problem is related to this issue: yarnpkg/yarn#685
The problem is that yarn copies the entire folder from
./tripetto-block-text/to./app/node_modules/tripetto-block-text. This also includes thenode_modulesfolder in./tripetto-block-text/node_modulesand this folder also contains a version of thetripettopackage. So now, the text block will use this local instance of Tripetto to register itself to instead of the one used by your app.The solution here is to run
npm packwhich respects the.npmignorefile. This will exclude some folders includingnode_modules. After that, the resulting tarball can be used to install the package.