Add option for orthographic projections to sim depth cameras #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomascent
added
the
Minor Update
Yuki-cpp
suggested changes
May 19, 2022
Co-authored-by: Leo <35804463+Yuki-cpp@users.noreply.github.com>
|
@Yuki-cpp , makes sense, thanks for the review! |
Yuki-cpp
approved these changes
May 19, 2022
danielcranston
requested changes
May 19, 2022
There was a problem hiding this comment.
Nice feature!
Can we extend the test (https://github.com/ascentai/gl_depth_sim/blob/master/gl_depth_sim/test/utest.cpp) in some way to cover this? I have no idea if those values are correct.
Also, it seems CI is not run on PRs?
danielcranston
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When checking whether two objects overlap it's useful to be able to render their depth map using an orthographic projection. This PR adds that functionality to
gl_depth_sim!To do that, I just added an enum for whether the camera was a perspective or othrographic projection type and modified the projection matrix accordingly