Update asciidoctorj to 2.4.2 and java version to 8 #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apj68
reviewed
Feb 26, 2021
There was a problem hiding this comment.
I used this update to get up and running with asciidoctorj-diagram. I had to add:
asciidoclet 'fr.jmini.asciidoctorj:file-logger:1.0.0'
asciidoclet 'com.google.guava:guava:20.0'
I don't know if I was doing something wrong but adding those as well as this pull #104 worked well for me. Thanks for submitting it!
Configure Renovate
…gins-maven-shade-plugin-3.x Update dependency org.apache.maven.plugins:maven-shade-plugin to v3.4.1
…le-2.x Update dependency org.slf4j:slf4j-simple to v2
…lnarion-parent-pom-2.x Update dependency de.elnarion.maven:elnarion-parent-pom to v2.0.7
Bumps [guava](https://github.com/google/guava) from 31.1-jre to 32.0.0-jre. - [Release notes](https://github.com/google/guava/releases) - [Commits](https://github.com/google/guava/commits) --- updated-dependencies: - dependency-name: com.google.guava:guava dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…a-guava-32.0.0-jre Bump guava from 31.1-jre to 32.0.0-jre
|
I think we can close this after recent work. The current repo uses the latest AsciidoctorJ 2.5.12 and is compatible with Java 11,17 and 21. Thanks to all collaborators for the work and time, truly 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2019 the asciidoctorj implementation switched to 2.x and changed the minimum Java version to 8.
This change fixed many issues with extensions, but also brought some incompatible changes in the extension api with the 1.5.x. version of asciidoctorj (currently used by asciidoclet).
To be able to use the new generation of asciidoctorj extensions in asciidoclet the version of asciidoctorj needs to be upgraded to 2.x (e.g. current stable version 2.4.2).