-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 2.2.13 triggers an errors for wavedrom diagrams #441
Comments
Note that this only seems to occur on Linux. |
Sorry about that. I'll see if I can reproduce this asap. Pretty sure this is caused by the changes in c0c8c3f#diff-ab2488253f29128584bd1309a0c98459ef7a13471bf4d66e598c5c62e1d50c75R21 |
After rereading the Wavedrom code this change doesn't make much sense since the first thing it will do is write the content from stdin to a temporary file which is exactly what the gem was doing before as well.
I'm getting the same error on macOS as well. I had forgotten about the fact the Wavedrom unit tests were disabled in the GitHub Actions test runs which is how I missed the regression. I'm reverting the problematic change and will make a new release shortly to resolve the problem. |
After rereading the Wavedrom code this change doesn't make much sense since the first thing it will do is write the content from stdin to a temporary file which is exactly what the gem was doing before as well.
After rereading the Wavedrom code this change doesn't make much sense since the first thing it will do is write the content from stdin to a temporary file which is exactly what the gem was doing before as well.
With the release of version 2.2.13 the following error is occurring for wavedrom diagrams:
asciidoctor-pdf -r asciidoctor-diagram ./sample.adoc
asciidoctor: ERROR: sample.adoc: line 10: Failed to generate image: wavedrom-cli failed: internal/fs/utils.js:581
throw new ERR_INVALID_ARG_TYPE(propName, ['string', 'Buffer', 'URL'], path);
^
TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string or an instance of Buffer or URL. Received type boolean (true)
at readFile (fs.js:317:10)
at go$readFile (/usr/local/lib/node_modules/wavedrom-cli/node_modules/graceful-fs/graceful-fs.js:118:14)
at Object.readFile (/usr/local/lib/node_modules/wavedrom-cli/node_modules/graceful-fs/graceful-fs.js:115:12)
at Object.readFile (/usr/local/lib/node_modules/wavedrom-cli/node_modules/universalify/index.js:5:57)
at Object. (/usr/local/lib/node_modules/wavedrom-cli/wavedrom-cli.js:36:4)
at Module._compile (internal/modules/cjs/loader.js:999:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
at Module.load (internal/modules/cjs/loader.js:863:32)
at Function.Module._load (internal/modules/cjs/loader.js:708:14)
at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12) {
code: 'ERR_INVALID_ARG_TYPE'
}
The text was updated successfully, but these errors were encountered: