Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle case when admonition block spans more than one page #1287

Closed
mojavelinux opened this issue Sep 22, 2019 · 2 comments
Closed

Handle case when admonition block spans more than one page #1287

mojavelinux opened this issue Sep 22, 2019 · 2 comments
Assignees
@mojavelinux
Labels
bug compliance
Milestone
v1.5.0.rc.3

Comments

@mojavelinux
Copy link
Member

When the height of an admonition block exceeds one page, the line between the label and the content extends into the footer on the first page, then stops. The line should break with the content and continue onto subsequent pages.
@mojavelinux
Copy link
Member Author

The solution should follow the same logic that was used for example and sidebar blocks. See #362 and #259.

@mojavelinux mojavelinux added this to the v2.0.0 milestone Dec 31, 2019
@mojavelinux
Copy link
Member Author

The label should be vertically centered within the available height on the first page.

@mojavelinux mojavelinux self-assigned this Jan 19, 2020
@mojavelinux mojavelinux modified the milestones: v2.0.0, v1.5.0 Jan 19, 2020
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Jan 19, 2020
@mojavelinux
resolves asciidoctor#1287 continue border, background, and column rul…
f59a106 
…e of admonition block on subsequent pages
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Jan 20, 2020
@mojavelinux
resolves asciidoctor#1287 continue border, background, and column rul…
49fa406 
…e of admonition block on subsequent pages
@mojavelinux mojavelinux modified the milestones: v1.5.0, v1.5.0.rc.3 Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojavelinux mojavelinux

Labels
bug compliance
Projects
None yet
Milestone
v1.5.0.rc.3
Development

No branches or pull requests
1 participant
@mojavelinux