Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply point conversion to image sizes on title page and in running header/footer #221

Closed
mojavelinux opened this issue Jun 24, 2015 · 0 comments
Closed

Apply point conversion to image sizes on title page and in running header/footer #221

mojavelinux opened this issue Jun 24, 2015 · 0 comments
Assignees
@mojavelinux
Labels
compliance
Milestone
v1.5.0.alpha.9

Comments

@mojavelinux
Copy link
Member

Apply the same point conversion used for block images to the images on the title page and in the running/header footer.

The conversion is as follows:

  • native width or width attribute is assumed to be pixels, so multiply by 75% to get point value
  • prevent width of image from stretching wider than page (100% max width)
  • add support for the pdfwidth attribute
@mojavelinux mojavelinux self-assigned this Jun 24, 2015
@mojavelinux mojavelinux added this to the v1.5.0 milestone Jun 24, 2015
@mojavelinux mojavelinux modified the milestones: v1.5.0.alpha.9, v1.5.0 Jul 21, 2015
@mojavelinux mojavelinux changed the title Apply point conversion to image sizes on title page and in running header/footer Apply point conversion to image sizes on title page and running header/footer Jul 29, 2015
@mojavelinux mojavelinux changed the title Apply point conversion to image sizes on title page and running header/footer Apply point conversion to image sizes on title page and in running header/footer Jul 29, 2015
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Jul 29, 2015
@mojavelinux
resolves asciidoctor#221 apply point conversion to image widths
cbe9064 
- apply point conversion to width of images on title page
- apply point conversion to width of images in running header/footer
- don't allow image in running header/footer to overrun page (shrink to fit)
- only hide title page if notitle is set (not noheader)
- use ThemeLoader.resolve_theme_asset to resolve path of title-logo-image
- add method to calculate intrinsic dimensions of image
- document fallback running footer content in theming guide
- document the effect the notitle, noheader & nofooter attributes have in theming guide
- minor cleanups
mojavelinux added a commit that referenced this issue Jul 30, 2015
@mojavelinux
Merge pull request #285 from mojavelinux/issue-221
754cfef 
resolves #221 apply point conversion to image widths
@mojavelinux mojavelinux removed the next label Oct 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojavelinux mojavelinux

Labels
compliance
Projects
None yet
Milestone
v1.5.0.alpha.9
Development

No branches or pull requests
1 participant
@mojavelinux