Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertical alignment in running header/footer should permit the value "middle" #264

Closed
mojavelinux opened this issue Jul 13, 2015 · 1 comment
Closed

Vertical alignment in running header/footer should permit the value "middle" #264

mojavelinux opened this issue Jul 13, 2015 · 1 comment
Assignees
@mojavelinux
Labels
compliance
Milestone
v1.5.0.alpha.9

Comments

@mojavelinux
Copy link
Member

The vertical alignment settings (valign and image_valign) in the running header/footer should allow the value "middle" for alignment to the midpoint as an alias for "center". This brings the value inline with CSS.
@mojavelinux mojavelinux self-assigned this Jul 13, 2015
@mojavelinux mojavelinux added this to the v1.5.0 milestone Jul 13, 2015
@mojavelinux
Copy link
Member Author

I think we should also change the name of the property from valign to vertical-align since our stated goal is to align with CSS conventions.

mojavelinux added a commit that referenced this issue Jul 13, 2015
@mojavelinux
Merge pull request #265 from mojavelinux/issue-264
6a07809 
resolves #264 modify vertical alignment setting for running header/footer
mojavelinux added a commit that referenced this issue Jul 14, 2015
@mojavelinux
fix typo in fix for #264
ea09084
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojavelinux mojavelinux

Labels
compliance
Projects
None yet
Milestone
v1.5.0.alpha.9
Development

No branches or pull requests
2 participants
@mojavelinux @graphitefriction