Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering of two images in header or footer fails #421

Closed
fbasler opened this issue Apr 22, 2016 · 2 comments
Closed

Rendering of two images in header or footer fails #421

fbasler opened this issue Apr 22, 2016 · 2 comments
Assignees
Labels

Comments

@fbasler
Copy link

fbasler commented Apr 22, 2016

I tried to define a theme to be used by the asciidoctor-pdf renderer which displays two images in the header - one on the left, the other one on the right.

Here's the snippet from the theme.yml:

header:
height: 1.5in
recto_content:
right: image:gradle.png[width=200]
left: image:github.png[width=200]
verso_content:
right: $header_recto_content_right
left: $header_recto_content_left

Unfortunately it got rendered like this:

image

As you can see the image on the right is correctly aligned to the right but shifted down.
If I use a similar definition for the footer, only the left image is rendered - the right one is missing altogether.

Could you please have a look at it and fix the image alignment?
Thank you in advance.

Here's a minimal sample project showing the problem:
NoTwoHeaderImages.zip

mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Apr 23, 2016
@mojavelinux
Copy link
Member

Thanks for reporting! It looks like the cursor was not being properly reset after placing the image in the running content. As a result, the image on the other side was being placed below the other when they should be aligned vertically.

I've submitted a patch with a fix. I'll include this as part of the next alpha.

@mojavelinux mojavelinux added this to the v1.5.0.beta.1 milestone Apr 23, 2016
@mojavelinux mojavelinux self-assigned this Apr 23, 2016
mojavelinux added a commit that referenced this issue Apr 24, 2016
resolves #421 restore cursor position after placing image in running content
@fbasler
Copy link
Author

fbasler commented Apr 25, 2016

Thank you for the quick solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants