Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

links are html escaped but should not be #448

Closed
handcraftsman opened this issue May 22, 2016 · 2 comments
Closed

links are html escaped but should not be #448

handcraftsman opened this issue May 22, 2016 · 2 comments
Assignees
@mojavelinux
Labels
bug compliance
Milestone
v1.5.0.alpha.12

Comments

@handcraftsman
Copy link

The link

https://github.com?foo=1&bar=2[Hello World]

in the generated PDF goes to:

https://github.com/?foo=1&bar=2

The ampersand in the url is HTML escaped but should not be.
@mojavelinux mojavelinux added this to the v1.5.0.alpha.12 milestone May 24, 2016
@mojavelinux mojavelinux self-assigned this May 24, 2016
@mojavelinux
Copy link
Member

Nice catch! Our text parser handles character references in regular text, but it does not handle them inside attribute values. The main case of this is the link target. We can at least handle that case.

mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue May 24, 2016
@mojavelinux
resolves asciidoctor#448 decode character references in link URIs
5eb700e 
- decode character references (e.g., &) in link URIs
- update terminology for refering to character references
- minor code cleanups
@mojavelinux
Copy link
Member

PR sent!

fapdash pushed a commit to vogellacompany/asciidoctor-pdf that referenced this issue Dec 13, 2016
@mojavelinux @fapdash
resolves asciidoctor#448 decode character references in link URIs (PR a…
cad5109 
…sciidoctor#450)

- decode character references (e.g., &) in link URIs
- update terminology for refering to character references
- minor code cleanups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojavelinux mojavelinux

Labels
bug compliance
Projects
None yet
Milestone
v1.5.0.alpha.12
Development

No branches or pull requests
2 participants
@mojavelinux @handcraftsman