-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to show the link in the generated PDF #463
Comments
I propose the following attribute:
|
+1 assuming that the Asciidoctor Gradle task can use that. |
Absolutely. Note that this is similar to the option the DocBook toolchain named In addition to |
For reference, DocBook does it already nicely:
|
I prefer the round brackets to the square brackets. I think the square brackets don't kern well against the text and look too abrupt. |
Round brackets look also fine. As long as the link is visible in the printout. Without this option I have to decide if the HTML output will look "unusual" or if the PDF printout is harder to use, as the links are missing. |
- show URI for link if show-link-uri or media=print is set - surround URI with square brackets instead of round brackets - don't italicize URI
It turns out that this was already implemented, enabled by the showlinks attribute. However, I have updated the functionality so it works as described in this issue. Setting either of these two attributes will reveal the URI for any non-bare link:
I have also surrounded the link in square brackets in normal font with a slightly reduced font size (0.9em). |
- show URI for link if show-link-uri or media=print is set - surround URI with square brackets instead of round brackets - don't italicize URI
- show URI for link if show-link-uri or media=print is set - surround URI with square brackets instead of round brackets - don't italicize URI
Awesome, that will remove a lot of painful editing work for me. Can a new version of the plug-in be published? I do not see v1.5.0.alpha.12 yet in bintray: https://jcenter.bintray.com/org/asciidoctor/asciidoctorj-pdf/ |
The new version is available only as a RubyGem at the moment. (https://rubygems.org/gems/asciidoctor-pdf/versions/1.5.0.alpha.12). We have plans to set up an automated release pipeline so that AsciidoctorJ PDF releases get triggered automatically by Asciidoctor PDF (Ruby) releases. But we're not there yet. Btw, I'm going to be making another release in the next couple of days which bring a few more features you were looking for. Depending on Robert's availability, we might have AsciidoctorJ PDF skip the alpha.12 release and go right to alpha.13. |
Create a separate issue for the asciidoctorj release asciidoctor/asciidoctorj#505 |
👍 |
FYI - the old setting with :showlinks: does not work anymore. Totally fine for me, switching to :show-link-uri: is easy but I justed wanted to ensure that this is intentional and your are not breaking existing clients. |
That is correct. I renamed the attribute. Since we're still in alpha, there's no guarantee for backwards compatibility (though I've been careful not to cause too much disruption). |
- show URI for link if show-link-uri or media=print is set - surround URI with square brackets instead of round brackets - don't italicize URI
For printouts I would like to show the URL.
http://www.vogella.com[vogella] should be become something readable.
Maybe
vogella [http://www.vogella.com]
Is this option already available? If not, could you add it?
The text was updated successfully, but these errors were encountered: